[FIXED] CB broken on all Firefox versions higher than 43

Post information about bugs here

Re: Custom Buttons broken on all Firefox versions higher tha

Postby makondo » Sat Jan 30, 2016 5:56 pm

In about:config reset this to false: xpinstall.signatures.required
Then install the version from the first post.
makondo
 
Posts: 1587
Joined: Sun Dec 25, 2011 7:17 pm

Re: Custom Buttons broken on all Firefox versions higher tha

Postby leamphil » Fri Feb 12, 2016 11:30 am

Custom Buttons add-on makes Firefox 44.0.2 start-up really slowly (1 min +) - you can see the storage used ticking away as it starts. It does start eventually.

Updating to the version at the top of this topic fixed this.
leamphil
 
Posts: 5
Joined: Fri Feb 12, 2016 11:28 am

Re: Custom Buttons broken on all Firefox versions higher tha

Postby Nux » Fri Feb 12, 2016 6:07 pm

Update: an update is available through AMO so just install 0.0.5.8.2 normally. Ignore below.

All steps to install a working version for Firefox 44:

  1. Download "custom_buttons-0.0.5.8-tb+fx+sm.zip" (from the first post).
  2. Rename "custom_buttons-0.0.5.8-tb+fx+sm.zip" to "custom_buttons-0.0.5.8-tb+fx+sm.xpi".
  3. Open "about:config".
  4. Change "xpinstall.signatures.required" flag to `false`.
  5. (optionally) Disable all unsigned extensions you already had (otherwise they will be installed upon next Firefox restart).
  6. Uninstall current Custom Buttons extension (don't worry your buttons will only disappear for a moment).
  7. Restart Firefox.
  8. Drag "custom_buttons-0.0.5.8-tb+fx+sm.xpi" and Drop onto your Firefox.

After restart all your buttons should be back.
Last edited by Nux on Mon Feb 15, 2016 12:05 am, edited 2 times in total.
Nux
 
Posts: 7
Joined: Mon Nov 23, 2015 1:47 am

Re: Custom Buttons broken on all Firefox versions higher tha

Postby antonglv » Sat Feb 13, 2016 12:26 pm

Odyseus, thank you for the bug fixes.

Fixed on the sources, see

https://sourceforge.net/p/custombuttons ... b66a06b7d/
https://sourceforge.net/p/custombuttons ... 2c81e5fa9/

and uplodaded on AMO for review.

Build 0.0.5.8.2 is available for download on sourceforge.net: https://sourceforge.net/projects/custombuttons/files/
antonglv
Site Admin
 
Posts: 62
Joined: Wed Dec 21, 2011 3:56 pm

Re: Custom Buttons broken on all Firefox versions higher tha

Postby makondo » Sat Feb 13, 2016 4:56 pm

Thanks for the update, antonglv!
makondo
 
Posts: 1587
Joined: Sun Dec 25, 2011 7:17 pm

Re: Custom Buttons broken on all Firefox versions higher tha

Postby Infocatcher » Mon Feb 15, 2016 7:50 am

antonglv wrote:Fixed on the sources, see ...

Also should be fixed in custombuttons.jar\content\custombuttons\overlay.js (const -> var):
Code: Select all
const custombuttonsUtils = {
...
const createMsg = custombuttonsUtils. createMsg;
const gClipboard = custombuttonsUtils. gClipboard;

(also now becomes non-global variables)
Infocatcher
 
Posts: 119
Joined: Sat Jul 21, 2012 5:04 pm

Re: Custom Buttons broken on all Firefox versions higher tha

Postby antonglv » Mon Feb 15, 2016 1:45 pm

Infocatcher wrote:
antonglv wrote:Fixed on the sources, see ...

Also should be fixed in custombuttons.jar\content\custombuttons\overlay.js (const -> var):
Code: Select all
const custombuttonsUtils = {
...
const createMsg = custombuttonsUtils. createMsg;
const gClipboard = custombuttonsUtils. gClipboard;

(also now becomes non-global variables)


Yes, I saw bunda's post on MRO. To say the truth there are far much more to fix :)

Fixed on the sources: https://sourceforge.net/p/custombuttons/code/ci/093696105258f4b26d35b6ae9d277745b5349d8f/

Build 0.0.5.8.3 is available for download on sourceforge.net: https://sourceforge.net/projects/custombuttons/files/
antonglv
Site Admin
 
Posts: 62
Joined: Wed Dec 21, 2011 3:56 pm

Re: Custom Buttons broken on all Firefox versions higher tha

Postby makondo » Mon Feb 15, 2016 3:01 pm

Thanks for the update!
makondo
 
Posts: 1587
Joined: Sun Dec 25, 2011 7:17 pm

Re: Custom Buttons broken on all Firefox versions higher tha

Postby Odyseus » Tue Feb 16, 2016 1:33 am

Hello, everybody.

@antonglv: Infinite thanks for updating Custom Buttons!!!

Seeing that you are active these days, I would like to take this opportunity to "implore you" that you see if you can fix the initialization problem with the "menu" and "menu-button" types (as reported here and here). In a nutshell, "menu" type buttons are initialized twice and "menu-button" type buttons are initialized thrice (three times!). While it is relatively simple to avoid the problems this can cause, lately it is becoming a real headache.

Also, while you are at it, you could add the Spanish translation for Custom Buttons add-on posted here.

Again, thank you very much for keeping Custom Buttons alive, antonglv and all contributors!!!

Image
Odyseus
 
Posts: 434
Joined: Sun Mar 10, 2013 12:51 pm

Re: Custom Buttons broken on all Firefox versions higher tha

Postby antonglv » Wed Feb 17, 2016 3:30 pm

Odyseus wrote:Seeing that you are active these days, I would like to take this opportunity to "implore you" that you see if you can fix the initialization problem with the "menu" and "menu-button" types (as reported here and here). In a nutshell, "menu" type buttons are initialized twice and "menu-button" type buttons are initialized thrice (three times!). While it is relatively simple to avoid the problems this can cause, lately it is becoming a real headache.


As far as I climb on a career ladder I have less and lesser free time to develop the add-on :( But I would not want to disappoint the add-on's users (and myself), therefore I'll try to jump over my head. I won't promise but I hope I succeed.

Also, while you are at it, you could add the Spanish translation for Custom Buttons add-on posted here.


Done: https://sourceforge.net/p/custombuttons/code/ci/0c63eaedc3ec3fa5f4fcc06cf6b84665c40b1daf/
Couldn't you test it? (build 0.0.5.8.4 at https://sourceforge.net/projects/custombuttons/files/)
antonglv
Site Admin
 
Posts: 62
Joined: Wed Dec 21, 2011 3:56 pm

PreviousNext

Return to Bug report

cron