[Signed fixed extension attached] CB broken on Firefox 48+

Post information about bugs here

Re: [Signed fixed extension attached] CB broken on Firefox 4

Postby spirit » Thu Mar 29, 2018 3:08 am

Infocatcher wrote:Yet another fixes up to Firefox 61.0a1 (2018-03-18)
Also still thanks to Dumby.

Not signed: custom_buttons-0.0.5.8.9-fixed8.xpi
Signed: custom_buttons-0.0.5.8.9-fixed8-signed.xpi

In about:config, to install:
extensions.allow-non-mpc-extensions = true
extensions.legacy.enabled = true
Tricks for unsigned versions:
https://forum.mozilla-russia.org/viewtopic.php?id=70326
To force enable e10s mode:
browser.tabs.remote.force-enable = true


Installing this files working? When I try install I get infos that files are corrupted.
spirit
 
Posts: 5
Joined: Fri Nov 15, 2013 4:57 pm

Re: [Signed fixed extension attached] CB broken on Firefox 4

Postby Gabarito » Sat Apr 28, 2018 7:15 pm

morat wrote:Many thanks to Dumby and Infocatcher.

@trapper john

Here is how to install legacy extensions without hacking the omni.ja file. It works in Firefox 58 release build. It's still working in Firefox 59 release build.

* <installation directory>\defaults\pref\autoconfig.js ( e.g. C:\FirefoxPortable\App\Firefox\defaults\pref\autoconfig.js )

Code: Select all
// autoconfig.js file needs to start with a comment line

pref("general.config.filename", "mozilla.cfg");
pref("general.config.obscure_value", 0);

* <installation directory>\mozilla.cfg ( e.g. C:\FirefoxPortable\App\Firefox\mozilla.cfg )

Code: Select all
// mozilla.cfg file needs to start with a comment line

// Disable Signing Requirement
// Enable Legacy Extensions
// Enable Non Multiprocess Compatible Extensions

pref("xpinstall.signatures.required", false);
pref("extensions.legacy.enabled", true);
pref("extensions.allow-non-mpc-extensions", true);

var scope = Components.utils.import("resource://gre/modules/AppConstants.jsm");
scope.AppConstants = Object.assign({}, AppConstants, {
  MOZ_REQUIRE_SIGNING: false,
  MOZ_ALLOW_LEGACY_EXTENSIONS: true,
});

I got the following Custom Buttons working in Firefox 58 release build. It's still working in Firefox 59 release build.

custom_buttons-0.0.5.8.9-fixed7pre.xpi
viewtopic.php?p=77941#p77941

I got DOM Inspector Plus 2.0.17.1.2rc and Attributes Inspector working in Firefox 58 release build. However, it's broken in Firefox 59 release build.

DOM Inspector Plus
http://addons.mozilla.org/firefox/addon/254571

Also,

When Custom Buttons breaks, I will use the CustomizableUI to create buttons.

Firefox Quantum compatible userChrome.js
http://github.com/Sporif/firefox-quantum-userchromejs

Restart Button
http://gist.github.com/Sporif/ad6e917d8 ... 80d3c8918c

* OpenPageInfoFirefoxButton_Movable.uc.js

Code: Select all
(function () {
  if (location != "chrome://browser/content/browser.xul") return;

  /* CustomizableUI
     http://developer.mozilla.org/docs/Mozilla/JavaScript_code_modules/CustomizableUI.jsm
  */

  try {
    CustomizableUI.createWidget({
      id: "open-page-info-button", // should match id below
      type: "custom",
      defaultArea: CustomizableUI.AREA_MENUBAR,
   // defaultArea: CustomizableUI.AREA_NAVBAR,
      onBuild: function (aDocument) {
        var XUL_NS = "http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul";
        var toolbaritem = aDocument.createElementNS(XUL_NS, "toolbarbutton");
        toolbaritem.onclick = event => onClick(event);
        var props = {
          id: "open-page-info-button",
          class: "toolbarbutton-1 chromeclass-toolbar-additional",
          label: "Open Page Info",
          tooltiptext: "Open page info window for current page",
          style: 'list-style-image: url("chrome://branding/content/icon16.png");',
        };
        for (var p in props) toolbaritem.setAttribute(p, props[p]);
        return toolbaritem;
      },
    });
  } catch (e) {};

  function onClick(event) {
    if (event.button == 0) {
      Services.console.logStringMessage("test open page info button");
      BrowserPageInfo();
    }
  }
})();

CustomizableUI
http://developer.mozilla.org/en-US/docs ... ableUI.jsm


Sorry for quoting the big post above, but I'd like to ask if it's still valid nowadays.

I was using Firefox 56.0 with a workable version of Custom Buttons (0.0.5.8.9.1)
Firefox suggested too many times to update and I got to 59.0.
No Custom Buttons anymore. :(

So, what the steps to recover my previous customized buttons?

Thanks to Morat for his detailed guidance above, but I'm afraid that it won't work anymore.
Gabarito
 
Posts: 6
Joined: Fri Feb 19, 2016 11:25 am

Re: [Signed fixed extension attached] CB broken on Firefox 4

Postby morat » Sat Apr 28, 2018 7:51 pm

@Gabarito

The release date for Firefox 60 is May 9th.

Release Calendar
http://wiki.mozilla.org/Release_Management/Calendar

AFAIK, the mozilla.cfg hack will fail in Firefox 60.

I do not want to rewrite your buttons for the CustomizableUI.
morat
 
Posts: 959
Joined: Wed Dec 28, 2011 2:38 pm

Re: [Signed fixed extension attached] CB broken on Firefox 4

Postby trapper john » Sat Apr 28, 2018 10:06 pm

Since the 60 unbranded version enables legacy addons there must be an internal switch somewhere or hack code that can be used to do the same with the official releases.

Infocatcher: if you get a chance could you post on the Russian site and see if Dumby might know? If anyone does it's him.
trapper john
 
Posts: 120
Joined: Wed Mar 14, 2012 6:58 pm

Re: [Signed fixed extension attached] CB broken on Firefox 4

Postby Gabarito » Sat Apr 28, 2018 11:10 pm

morat wrote:
AFAIK, the mozilla.cfg hack will fail in Firefox 60.

I do not want to rewrite your buttons for the CustomizableUI.


As far I understood, Firefox 60 and ahead won't allow Custom Buttons, even hacked ones, doesn't it?
It means the CB's death?
If so, do you recommend some other extension that does the same?
Gabarito
 
Posts: 6
Joined: Fri Feb 19, 2016 11:25 am

Re: [Signed fixed extension attached] CB broken on Firefox 4

Postby Gabarito » Sat Apr 28, 2018 11:12 pm

trapper john wrote:Since the 60 unbranded version enables legacy addons there must be an internal switch somewhere or hack code that can be used to do the same with the official releases.


If we had some hope to save this very nice extension, let's try it.
;)
Gabarito
 
Posts: 6
Joined: Fri Feb 19, 2016 11:25 am

Re: [Signed fixed extension attached] CB broken on Firefox 4

Postby trapper john » Sat Apr 28, 2018 11:25 pm

Dumby's latest CB version works good in FF60 but is dead again in 61 but I think legacy is killed for good in the latest nightlies, although I'm not sure since I haven't bothered with those in the last month.

For 60 unless they have unbranded esr releases it's dead as well unless we can find a way to enable legacy addons.
trapper john
 
Posts: 120
Joined: Wed Mar 14, 2012 6:58 pm

Re: [Signed fixed extension attached] CB broken on Firefox 4

Postby morat » Sun Apr 29, 2018 5:09 am

Custom Buttons is already dead. Infocatcher is using raise dead magic to get the legacy extension working.

@trapper john

We could hack the omni.ja file, but a mozilla.cfg hack may not be possible.

The extensions.legacy.enabled pref is still available in Fx 60 and Fx 61.

http://dxr.mozilla.org/mozilla-release/search?q=extensions.legacy.enabled
http://dxr.mozilla.org/mozilla-release/source/browser/config/version.txt
http://dxr.mozilla.org/mozilla-beta/search?q=extensions.legacy.enabled
http://dxr.mozilla.org/mozilla-beta/source/browser/config/version.txt
http://dxr.mozilla.org/mozilla-central/search?q=extensions.legacy.enabled
http://dxr.mozilla.org/mozilla-central/source/browser/config/version.txt

@Gabarito

I will use the CustomizableUI to create buttons.

Similar WebExtension:

Foxy Gestures
http://addons.mozilla.org/firefox/addon/foxy-gestures/
http://github.com/marklieberman/foxygestures

Foxy Gestures User Scripts
http://github.com/marklieberman/foxygestures/wiki/User-Scripts

Examples
http://forums.mozillazine.org/viewtopic.php?f=23&t=3033676

(see the last post on how to use old school APIs like nsIFile)
morat
 
Posts: 959
Joined: Wed Dec 28, 2011 2:38 pm

Re: [Signed fixed extension attached] CB broken on Firefox 4

Postby trapper john » Sun Apr 29, 2018 2:26 pm

@morat, the first link appears to have the switches but would you know which one specifically would enable legacy addons in desktop 60? It looks like it might be this one:

const PREF_LEGACY_ENABLED = "extensions.legacy.enabled";
toolkit/mozapps/extensions/internal/AddonSettings.jsm
trapper john
 
Posts: 120
Joined: Wed Mar 14, 2012 6:58 pm

Re: [Signed fixed extension attached] CB broken on Firefox 4

Postby morat » Sun Apr 29, 2018 2:49 pm

AFAIK, the Fx Beta 60 omni.ja file hack is the same as the Fx Beta 57 omni.ja file hack. (not tested)

More info: viewtopic.php?p=71701#p71701

trapper john wrote:I think legacy is killed for good in the latest nightlies.

I think the devs would remove the extensions.legacy.enabled pref when they kill the legacy feature.
morat
 
Posts: 959
Joined: Wed Dec 28, 2011 2:38 pm

PreviousNext

Return to Bug report

cron